Feature flag naming fix#6182
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request corrects a naming inconsistency in a feature flag used to determine if Stat Var search is supported. By aligning the flag name with the project's naming conventions, it ensures that the search functionality behaves correctly in environments where multiple feature flags are active simultaneously. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the feature flag name used in the search support check within server/routes/tools/html.py. Feedback suggests replacing the hardcoded feature flag string with a predefined constant to ensure consistency and prevent potential typos.
Description
The feature flag criteria for determining whether or not VAI was on was incorrectly named (named using the constant naming convention rather than the feature flag naming convention).
In environments where V2 was on and VAI was on (but NL server was off) the Stat Var search was incorrectly being hidden.