Skip to content

Feature flag naming fix#6182

Merged
nick-nlb merged 2 commits intodatacommonsorg:masterfrom
nick-nlb:feature_flag_name_fix
Apr 6, 2026
Merged

Feature flag naming fix#6182
nick-nlb merged 2 commits intodatacommonsorg:masterfrom
nick-nlb:feature_flag_name_fix

Conversation

@nick-nlb
Copy link
Copy Markdown
Contributor

@nick-nlb nick-nlb commented Apr 6, 2026

Description

The feature flag criteria for determining whether or not VAI was on was incorrectly named (named using the constant naming convention rather than the feature flag naming convention).

In environments where V2 was on and VAI was on (but NL server was off) the Stat Var search was incorrectly being hidden.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request corrects a naming inconsistency in a feature flag used to determine if Stat Var search is supported. By aligning the flag name with the project's naming conventions, it ensures that the search functionality behaves correctly in environments where multiple feature flags are active simultaneously.

Highlights

  • Feature Flag Renaming: Renamed the 'vai_for_statvar_search_feature_flag' flag to 'vai_for_statvar_search' to adhere to standard naming conventions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the feature flag name used in the search support check within server/routes/tools/html.py. Feedback suggests replacing the hardcoded feature flag string with a predefined constant to ensure consistency and prevent potential typos.

Comment thread server/routes/tools/html.py Outdated
@nick-nlb nick-nlb requested a review from n-h-diaz April 6, 2026 23:26
@nick-nlb nick-nlb marked this pull request as ready for review April 6, 2026 23:26
@nick-nlb nick-nlb merged commit f950bca into datacommonsorg:master Apr 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants