Update the code to only do single time feature flag call within 1 Gemini client#6209
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes how feature flags are handled when interacting with the Gemini client. By shifting the responsibility of checking the feature flag to the call sites, the code reduces redundant checks and improves the modularity of the Gemini utility functions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the Gemini configuration logic by moving the feature flag check for 'thinking configuration' from the utility layer to the calling sites in overview.py and related.py. The call_gemini and get_gemini_config functions now explicitly accept a use_thinking_config boolean parameter. Feedback was provided regarding the call_gemini docstring, which incorrectly documents a retries parameter that is not present in the function signature or implementation.
No description provided.