Skip to content

Update the code to only do single time feature flag call within 1 Gemini client#6209

Merged
shixiao-coder merged 3 commits intodatacommonsorg:masterfrom
shixiao-coder:fix-gemini-feature-flag-issue
Apr 15, 2026
Merged

Update the code to only do single time feature flag call within 1 Gemini client#6209
shixiao-coder merged 3 commits intodatacommonsorg:masterfrom
shixiao-coder:fix-gemini-feature-flag-issue

Conversation

@shixiao-coder
Copy link
Copy Markdown
Contributor

No description provided.

@shixiao-coder shixiao-coder requested a review from gmechali April 15, 2026 14:03
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes how feature flags are handled when interacting with the Gemini client. By shifting the responsibility of checking the feature flag to the call sites, the code reduces redundant checks and improves the modularity of the Gemini utility functions.

Highlights

  • Refactored Feature Flag Logic: Moved the feature flag check for Gemini 3 thinking configuration out of the utility function and into the calling modules.
  • Improved API Flexibility: Updated the call_gemini and get_gemini_config functions to accept a use_thinking_config boolean parameter, allowing callers to explicitly control the configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Gemini configuration logic by moving the feature flag check for 'thinking configuration' from the utility layer to the calling sites in overview.py and related.py. The call_gemini and get_gemini_config functions now explicitly accept a use_thinking_config boolean parameter. Feedback was provided regarding the call_gemini docstring, which incorrectly documents a retries parameter that is not present in the function signature or implementation.

Comment thread server/lib/utils/gemini_utils.py Outdated
Comment thread server/lib/utils/gemini_utils.py Outdated
@shixiao-coder shixiao-coder merged commit 7aa4f42 into datacommonsorg:master Apr 15, 2026
13 checks passed
@shixiao-coder shixiao-coder deleted the fix-gemini-feature-flag-issue branch April 15, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants