Skip to content

[v0/v1 migration] Add fixed ordering for top-level hierarchy nodes#6238

Merged
nick-nlb merged 7 commits into
datacommonsorg:masterfrom
nick-nlb:spanner-top-level-stat-var-hierarchy-order
Apr 27, 2026
Merged

[v0/v1 migration] Add fixed ordering for top-level hierarchy nodes#6238
nick-nlb merged 7 commits into
datacommonsorg:masterfrom
nick-nlb:spanner-top-level-stat-var-hierarchy-order

Conversation

@nick-nlb
Copy link
Copy Markdown
Contributor

Issue

http://b/505060318

Description

The front end was previously rendering the top level of the stat var hierarchy in the order returned by the API. From the perspective of both mixer and the website, this order was effectively non-deterministic (i.e., the order was not being enforced in either mixer or the website), and was therefore being effectively curated upstream.

With the migration to Spanner, the order being returned was no longer the same.

With this PR, we are now enforcing Data Commons root nodes to be pinned in the order that matches the current production site (rather than relying on an arbitrary order from the database).

Screenshots

Before

image

After

image

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses non-deterministic rendering of top-level hierarchy nodes caused by the migration to Spanner. By introducing a pinned ordering configuration, the front end now enforces a consistent, production-aligned display order for root nodes, regardless of the order returned by the API.

Highlights

  • Fixed Ordering for Hierarchy Nodes: Implemented a deterministic sorting mechanism for top-level Data Commons hierarchy nodes to ensure consistent rendering across different database backends.
  • Configuration Update: Added a new 'topLevelPinnedOrder' configuration field to define the specific display order of root nodes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a configurable pinned order for top-level nodes in the statistical variable hierarchy and updates the configuration logic to merge default settings with global overrides. The review feedback identifies an opportunity to generalize the sorting logic by removing a specific check for the "dc/g/Root" node, ensuring that the pinned order and alphabetical sorting are applied consistently across different hierarchy roots.

Comment thread static/js/stat_var_hierarchy/stat_var_hierarchy.tsx Outdated
@nick-nlb nick-nlb marked this pull request as ready for review April 24, 2026 03:25
@nick-nlb nick-nlb requested review from juliawu and n-h-diaz April 24, 2026 23:54
Copy link
Copy Markdown
Contributor

@juliawu juliawu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Comment thread static/js/shared/ga_events.test.tsx Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be updated to index 1?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@nick-nlb nick-nlb merged commit cdb99d8 into datacommonsorg:master Apr 27, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants