[Gsutil to Gcloud] Reverting just the two commands in the Dockerfile.#6243
Conversation
…ly to download in the container from cloud build.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Dockerfile configurations for model and service downloads to support accessing public Google Cloud Storage buckets. By disabling credential requirements during the build process, the images can now successfully pull necessary assets without needing pre-configured authentication, ensuring a smoother build pipeline. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Dockerfiles for cdc_data and cdc_services to disable gcloud credentials before downloading models and embeddings. A review comment suggests optimizing the gcloud storage cp commands in the cdc_services Dockerfile by combining them into a single call to reduce build time.
We needed to specify to run the gcloud storage cp command wihtout auth since these are public buckets and we dont expect the authentication passed in to the image.
Tested successfully.