Skip to content

[Gsutil to Gcloud] Reverting just the two commands in the Dockerfile.#6243

Merged
gmechali merged 4 commits into
datacommonsorg:masterfrom
gmechali:revertgsutil
Apr 27, 2026
Merged

[Gsutil to Gcloud] Reverting just the two commands in the Dockerfile.#6243
gmechali merged 4 commits into
datacommonsorg:masterfrom
gmechali:revertgsutil

Conversation

@gmechali
Copy link
Copy Markdown
Contributor

We needed to specify to run the gcloud storage cp command wihtout auth since these are public buckets and we dont expect the authentication passed in to the image.

Tested successfully.

@gmechali gmechali requested a review from dhotchkiss April 27, 2026 14:08
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Dockerfile configurations for model and service downloads to support accessing public Google Cloud Storage buckets. By disabling credential requirements during the build process, the images can now successfully pull necessary assets without needing pre-configured authentication, ensuring a smoother build pipeline.

Highlights

  • Authentication Configuration: Added gcloud config set auth/disable_credentials True to Dockerfile build stages to allow access to public buckets without requiring explicit authentication.
  • Command Refinement: Updated gcloud storage cp commands to ensure compatibility and correct execution when fetching model and embedding files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Dockerfiles for cdc_data and cdc_services to disable gcloud credentials before downloading models and embeddings. A review comment suggests optimizing the gcloud storage cp commands in the cdc_services Dockerfile by combining them into a single call to reduce build time.

Comment thread build/cdc_services/Dockerfile Outdated
Comment thread build/cdc_data/Dockerfile
Comment thread build/cdc_services/Dockerfile Outdated
@gmechali gmechali merged commit 991de6b into datacommonsorg:master Apr 27, 2026
13 checks passed
@gmechali gmechali deleted the revertgsutil branch April 27, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants