Skip to content

Update screenshot suite URLs#6261

Merged
beets merged 3 commits into
datacommonsorg:masterfrom
beets:master
May 11, 2026
Merged

Update screenshot suite URLs#6261
beets merged 3 commits into
datacommonsorg:masterfrom
beets:master

Conversation

@beets
Copy link
Copy Markdown
Collaborator

@beets beets commented May 5, 2026

This PR curates the list of URLs used for Percy screenshot tests in urls.json. The previous list was excessively long (over 1000 lines) and repetitive, while still lacking coverage for several key features and parameters.

Key Changes

  • Pruned Repetitive URLs: Reduced the file size from over 1000 lines to a curated set of ~150 URLs, focusing on diversity of topics and geographies.
  • Improved Feature Coverage: Added missing pages and features to ensure full coverage of the site:
    • Static Pages: Added /about, /faq, and data sources.
    • Landing Pages: Added /place and /browser.
    • Explore with Parameters: Added examples with specific parameters for pinned maps/topics (Eurostat and Census data).
    • Ranking Pages: Added specific ranking pages for different place types and geographies (e.g., US Zip codes, India States).
  • Disaster Events: Ensured coverage for specific event pages (e.g., Drought in Algeria).
  • Curated Explore Queries: Pruned the long list of natural language queries to a small, diverse set covering different topics (Health, Econ, Education, Environment, Fallbacks) and geographies (US, India, Norway, Iran, Canada, Pakistan).

Verification

Verified that the updated file parses correctly as valid JSON.

@beets beets requested review from gmechali and nick-nlb May 5, 2026 21:32
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the configuration for Percy screenshot tests by significantly reducing the number of tracked URLs. The changes focus on improving the quality and diversity of the test suite, ensuring better coverage of core site features and representative data queries while maintaining a streamlined and efficient testing process.

Highlights

  • URL Curation: Pruned the list of URLs for Percy screenshot tests from over 1000 lines to a more manageable set of approximately 150, removing redundancies.
  • Feature Coverage: Expanded coverage to include static pages, landing pages, and specific parameters for pinned maps, topics, and ranking pages.
  • Explore Query Optimization: Curated the natural language query list to include a diverse set of topics and geographies while removing repetitive or low-value entries.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@beets
Copy link
Copy Markdown
Collaborator Author

beets commented May 5, 2026

Please help me ensure that critical parameters and paths are represented, thanks!

@beets beets requested a review from juliawu May 5, 2026 21:33
@beets beets changed the title Update urls.json Update screenshot suite URLs May 5, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes and prunes the urls.json file used for Percy snapshots, adding new landing pages for the home, about, and FAQ sections while standardizing visualization tool redirects. A significant number of specific explore query URLs were removed to streamline the snapshot process. Feedback was provided to standardize the /explore URL paths by removing trailing slashes before fragment identifiers to maintain consistency and prevent unnecessary redirects.

Comment on lines 111 to 122
"path": "/explore/#q=Obesity+vs+Unemployment+in+the+US+counties&mb=3&test=screenshot",
"name": "Explore: Obesity vs. Unemployment in US Counties"
},
{
"path": "/explore/#q=Businesses+by+industry+in+New+York+State&mb=3&test=screenshot",
"name": "Explore: Businesses by Industry in New York State"
},
{
"path": "/explore/#q=Health+equity+in+Santa+Clara+County&mb=3&test=screenshot",
"name": "Explore: Health Equity in Santa Clara County"
},
{
"path": "/explore/#q=Incarceration+rates+by+race+in+the+US&mb=3&test=screenshot",
"name": "Explore: Incarceration Rates by Race in the US"
},
{
"path": "/explore/#q=health+behaviors+in+India+vs+Norway&mb=3&test=screenshot",
"name": "Explore: Health Behaviors in India vs. Norway"
},
{
"path": "/explore/#q=High+blood+pressure+vs+Asthma+in+Alabama&mb=3&test=screenshot",
"name": "Explore: High Blood Pressure vs. Asthma in Alabama"
},
{
"path": "/explore/#q=School+Enrollment+in+California&mb=3&test=screenshot",
"name": "Explore: School Enrollment in California"
},
{
"path": "/explore/#q=Student+demographics+among+schools+in+Sunnyvale&mb=3&test=screenshot",
"name": "Explore: Student Demographics in Sunnyvale Schools"
},
{
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The URL paths for these explore queries use a trailing slash before the fragment identifier (/explore/#), while other explore URLs in this file (e.g., lines 103, 107, 123) do not. Standardizing on /explore# is preferred to maintain consistency and avoid potential unnecessary redirects during the snapshot process.

  {
    "path": "/explore#q=Obesity+vs+Unemployment+in+the+US+counties&mb=3&test=screenshot",
    "name": "Explore: Obesity vs. Unemployment in US Counties"
  },
  {
    "path": "/explore#q=health+behaviors+in+India+vs+Norway&mb=3&test=screenshot",
    "name": "Explore: Health Behaviors in India vs. Norway"
  },
  {
    "path": "/explore#q=Student+demographics+among+schools+in+Sunnyvale&mb=3&test=screenshot",
    "name": "Explore: Student Demographics in Sunnyvale Schools"
  },

Copy link
Copy Markdown
Contributor

@gmechali gmechali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

Comment thread tools/release_automation/percy_snapshot_script/urls.json
Copy link
Copy Markdown
Contributor

@juliawu juliawu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup! Just one comment.

Comment thread tools/release_automation/percy_snapshot_script/urls.json Outdated
Copy link
Copy Markdown
Contributor

@nick-nlb nick-nlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, thank you for this cleanup!

I went through the updated list and commented on a couple to put back in. Otherwise looks good.

Comment thread tools/release_automation/percy_snapshot_script/urls.json
Comment thread tools/release_automation/percy_snapshot_script/urls.json
@beets
Copy link
Copy Markdown
Collaborator Author

beets commented May 11, 2026

thanks for the reviews! updated based on comments - @juliawu could you re-approve?

Copy link
Copy Markdown
Contributor

@juliawu juliawu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating these!

@beets beets merged commit b62ba8b into datacommonsorg:master May 11, 2026
13 checks passed
@beets beets mentioned this pull request May 11, 2026
beets added a commit that referenced this pull request May 11, 2026
I missed the starting slash in one URL from the last PR #6261 :( ptal..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants