Updated website cron testing image#6274
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the webdriver-chrome image version across the repository's CI/CD pipeline and improves the security and maintainability of the containerized testing environments. By shifting to a more flexible base image tag and enforcing system package updates, the changes ensure that the testing infrastructure remains current and secure. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the webdriver-chrome image version to 2026-05-09 across CI configurations and Dockerfiles. Feedback was provided regarding the use of a floating Python tag in the webdriver-chrome Dockerfile, which can lead to non-deterministic builds, and the addition of a redundant apt-get upgrade step in the website_cron_testing Dockerfile that should be handled by the base image.
| # limitations under the License. | ||
|
|
||
| FROM python:3.11.6 | ||
| FROM python:3.11 |
There was a problem hiding this comment.
Using a floating tag like python:3.11 instead of a specific patch version (e.g., 3.11.6) makes the build non-deterministic. While this allows for automatic inclusion of security patches, it can also introduce unexpected regressions. For better reproducibility, consider pinning to a specific patch version or using a SHA256 digest.
|
Successfully built |
2 participants
This pull request updates the
webdriver-chromeDocker image and its usage throughout the CI/CD pipeline to use a newer version, along with a minor base image change and a security update in thewebsite_cron_testingimage.Docker image version updates:
webdriver-chromeimage version to2026-05-09in both thecloudbuild.yamlandcloudbuild.cdc_autopush.yamlfiles to ensure consistency across builds. NOTE: This build is not yet published. I'll publish it once this PR is approvedBase image and security improvements:
webdriver-chrome/Dockerfilefrompython:3.11.6to the more generalpython:3.11tag, which may pull the latest patch version.website_cron_testing/Dockerfileto runapt-get update && apt-get -y upgradefor improved security and up-to-date system packages.