#1756 generate 3-letter airport codes#1763
Conversation
PR Summary
|
c715dfd to
2658214
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1763 +/- ##
============================================
+ Coverage 92.32% 92.37% +0.05%
- Complexity 3439 3448 +9
============================================
Files 338 339 +1
Lines 6785 6794 +9
Branches 670 670
============================================
+ Hits 6264 6276 +12
+ Misses 355 353 -2
+ Partials 166 165 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds explicit support for generating airport codes by type (IATA vs ICAO) in the Aviation provider, including new backing datasets and tests.
Changes:
- Introduces
AirportCodeTypeenum (IATA,ICAO) and addsaviation.airport(AirportCodeType)overload. - Adds
flight(AirportCodeType)and deprecatesflight(String)in favor of the enum-based API. - Extends
en/aviation.ymlwithairport_iata/airport_icaodatasets and updatesAviationTestaccordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/test/java/net/datafaker/providers/base/AviationTest.java | Adds tests for airport code generation by type and updates deprecated flight tests. |
| src/main/resources/en/aviation.yml | Adds new IATA/ICAO airport code lists used by the new API. |
| src/main/java/net/datafaker/providers/base/Aviation.java | Adds enum-based overloads for airport/flight and deprecates legacy flight(String). |
| src/main/java/net/datafaker/providers/base/AirportCodeType.java | New enum defining supported airport code types. |
2658214 to
0891457
Compare
A.k.a. IATA code (passenger-friendly 3-letter code). This commit adds 1. enum `AirportCodeType (IATA | ICAO)` 2. method `aviation.airport(IATA)` -> 3-letter code 3. method `aviation.airport(ICAO)` -> 4-letter code
0891457 to
5bd5a4a
Compare
A.k.a. IATA code (passenger-friendly 3-letter code).
This commit adds
AirportCodeType (IATA | ICAO)aviation.airport(IATA)-> 3-letter codeaviation.airport(ICAO)-> 4-letter code