Conversation
…OSS UI
- Add BigQuery scan detection: BatchScan nodes with "Reading table [...]"
in their description get isBigQueryRead=true and the fully-qualified
table name; BQ metrics (bq rows, bq bytes read, bq scan/parse time, etc.)
are allowlisted, transformed, and renamed
- Add WriteToIceberg plan parser: extracts tableName and format from
IcebergWrite(table=..., format=...) descriptions for AppendData,
ReplaceData, WriteDelta, DeleteFromTable, OverwriteByExpression, and
OverwritePartitionsDynamic nodes; Iceberg-specific enriched names only
shown when the plan confirms it's actually an Iceberg write; generic
fallback names used otherwise
- Add PlanMetricsProcessor case for WriteToIceberg to display table name
and format in the UI
- Move sqlMetricsPatchApplied to shared SqlMetricsPatch object in
dataflint-common, eliminating duplication between pluginspark3 and
pluginspark4
menishmueli
requested changes
Mar 22, 2026
| libraryDependencies += "com.amazonaws" % "aws-java-sdk-s3" % "1.12.470" % "provided", | ||
| libraryDependencies += "org.apache.iceberg" %% "iceberg-spark-runtime-3.5" % "1.5.0" % "provided", | ||
| libraryDependencies += "io.delta" %% "delta-spark" % "3.2.0" % "provided", | ||
| libraryDependencies += "org.javassist" % "javassist" % "3.30.2-GA" % "provided", |
| "remote bytes read": "shuffle read (remote)", | ||
| "fetch wait time": "fetch wait time", | ||
| "data size": "shuffle data size", | ||
| "time spent in spark": "bq time in spark", |
Contributor
There was a problem hiding this comment.
Change names to out standard names. "number of BQ bytes read" should be "bytes read". "bq rows" to "rows"
…mpatibility
- Add google-cloud-dataproc, google-cloud-storage, and spark-bigquery-metrics JARs to the history server image, with version build args exposed in docker-compose
- Make Iceberg and BigQuery connector downloads graceful — skip with a warning instead of failing when the artifact doesn't exist for the given Spark version (fixes builds for Spark 4.1+)
spark-plugin: revert SQLMetrics javassist patch
- Remove SqlMetricsPatch.scala and its references from both pluginspark3 and pluginspark4 — the patch was reverted
- Remove javassist provided dependency from build.sbt
spark-ui: normalize BigQuery metric display names
- Remove the bq prefix from BigQuery metric labels in SqlReducerUtils.ts ("bq rows" → "rows", "bq scan time" → "scan time", etc.) for cleaner UI display
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.