Skip to content

fix: Force IMDSv2 just in case #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

fix: Force IMDSv2 just in case #66

merged 1 commit into from
Aug 27, 2025

Conversation

@gtoonstra
Copy link
Contributor

@gtoonstra gtoonstra commented Aug 26, 2025

What type of PR is this? (check all applicable)

  • fix: A bug fix

Description

@gtoonstra gtoonstra requested a review from a team as a code owner August 26, 2025 16:21
fpopa
fpopa reviewed Aug 26, 2025
View reviewed changes
Copy link
Contributor

@fpopa fpopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can configure the Instance Metadata Service (IMDS) on each instance so that local code or users must use IMDSv2. When you specify that IMDSv2 must be used, IMDSv1 no longer works. For information about how to configure your instance to use IMDSv2, see Configure the Instance Metadata Service options.

will we still use IMDSv1 anywhere?

@gtoonstra
Copy link
Contributor Author

gtoonstra commented Aug 27, 2025

You can configure the Instance Metadata Service (IMDS) on each instance so that local code or users must use IMDSv2. When you specify that IMDSv2 must be used, IMDSv1 no longer works. For information about how to configure your instance to use IMDSv2, see Configure the Instance Metadata Service options.

will we still use IMDSv1 anywhere?

I don't see that need. IMDSv2 has been around for a long time. Actually I think it's the default now in all of our regions.

@gtoonstra gtoonstra assigned lennart-damen and vvkh and unassigned vvkh Aug 27, 2025
@gtoonstra gtoonstra merged commit c2b94a3 into main Aug 27, 2025
4 checks passed
@gtoonstra gtoonstra deleted the gerard-eng-1749-cannot-deploy-aws-132 branch August 27, 2025 10:35
@devops-datafold
Copy link

devops-datafold commented Aug 27, 2025

This PR is included in version 1.14.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fpopa fpopa fpopa left review comments

@lennart-damen lennart-damen lennart-damen approved these changes

Assignees

@vvkh vvkh

@lennart-damen lennart-damen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gtoonstra @devops-datafold @fpopa @lennart-damen @vvkh