Update output for Data Preparation processing#1808
Conversation
| bool disabled = 6; | ||
|
|
||
| DataPreparationDefinition data_preparation = 7; | ||
| reserved 7; |
There was a problem hiding this comment.
Reserved fields should be at the end of messages
| const dataPreparationContents = nativeRequire(config.filename).asJson; | ||
| const dataPreparationDefinition = parseDataPreparationDefinitionJson(dataPreparationContents); |
There was a problem hiding this comment.
Nit: the term dataPreparationContents is overloaded now, so should be renamed - something like dataPreparationAsJson = ...
| ":bundle_with_license", | ||
| ":configs_proto_with_license", | ||
| ":core_proto_with_license", | ||
| ":data_preparation_proto_with_license", |
There was a problem hiding this comment.
You're still going to need this exported, for the decode step
There was a problem hiding this comment.
I added this back as discussed.
| } | ||
| ] | ||
| } | ||
| dataPreparationContents: "Cn4KBW5vZGUxEhASDgoDcHJqEgJkcxoDc3JjIlAiFgoUCgFhEgVJTlQ2NBoITlVMTEFCTEUqGyIZEhcKFQoBYRIGU1RSSU5HGghOVUxMQUJMRTIZChcKFQoBYRIGU1RSSU5HGghOVUxMQUJMRSoRCg8KA3ByahICZHMaBGRlc3Q=", |
There was a problem hiding this comment.
This is probably generated by some external script? Might be good to include that script / instruction on how to update this string.
There was a problem hiding this comment.
Good shout - @fernst if you bring back what you put here before, and just call dataform.DataPreparationDefinition.encode( on it in the test part, then its generation becomes clear
There was a problem hiding this comment.
Good point. I'll add this logic so it's obvious.
| } | ||
| ] | ||
| } | ||
| dataPreparationContents: "Cn4KBW5vZGUxEhASDgoDcHJqEgJkcxoDc3JjIlAiFgoUCgFhEgVJTlQ2NBoITlVMTEFCTEUqGyIZEhcKFQoBYRIGU1RSSU5HGghOVUxMQUJMRTIZChcKFQoBYRIGU1RSSU5HGghOVUxMQUJMRSoRCg8KA3ByahICZHMaBGRlc3Q=", |
There was a problem hiding this comment.
Good shout - @fernst if you bring back what you put here before, and just call dataform.DataPreparationDefinition.encode( on it in the test part, then its generation becomes clear
|
Our tests are being flakey atm because of the 
|
…aration contents after processing the data preparation definition.
fernst
force-pushed
the
update-datapreparation-encoding
branch
from
a38ea41 to
698ae58
Compare
3 participants
Updated data preparation proto to only carry binary encoded data preparation contents after processing the data preparation definition.