Conversation
Ekrekr
requested review from
a team,
Ceridan,
DiasDauletov and
Tuseeq1
and removed request for
a team,
Ceridan and
Tuseeq1
DiasDauletov
approved these changes
Dec 30, 2024
Contributor
Author
|
Tests passing manually, CI still broken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Individual fields under
publishare already tested by the config parameters test, e.g.dataform/core/main_test.ts
Line 1883 in b951c38
This avoids us type locking in session the publish method - which allows updating the interface, and is safe because it's not officially supported yet #1168. Directly hooking in with
sessionisn't really something we document.This unblocks #1780.