Conversation
At the moment external contributors can't run integration tests because they have no access to the GCP project used for tests. Split allows to run integration tests only on PR.
Ceridan
requested review from
DiasDauletov,
Ekrekr and
Tuseeq1
and removed request for
a team and
DiasDauletov
Ekrekr
approved these changes
Jan 27, 2025
Contributor
Ekrekr
left a comment
Ekrekr
left a comment
There was a problem hiding this comment.
Nice, this should help people a lot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment external contributors can't run integration tests because they have no access to the GCP project used for tests. Split allows external contributors to run
./scripts/run_testswithout any issues (in fact only unit tests will run). Integration tests will run on PR.Related issue: #1755