Merged
Conversation
Ceridan
approved these changes
Feb 20, 2025
Contributor
There was a problem hiding this comment.
Could you please explain what is the current responsibility of main_test.ts?
Contributor
Author
There was a problem hiding this comment.
I think pretty much everything could be moved to separate test files!
So currently it's mainly a proxy for testing session, because session doesn't really work without the code in main. But this could all moved under a session_test.ts file.
Things like SQLX testing in here are needed here because the literal JS parsing during SQLX compiling changes when passed through all the layers like this:
Line 85 in 3035b54
compilers_test.ts, and call the methods in run_core.ts, like the actions tests do now.
Workflow settings could be moved to workflow_settings_test.ts, and general action configs tests could be moved to actions/index_test.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bit hard to review sorry, but good to get over with! All the same tests remain, apart from a duplicate test for disabled options, but just moved. Plus some shared library changes.
I also want to: