Support generic compilation options#2145
Merged
rafal-hawrylak merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
rafal-hawrylak
requested review from
andrzej-grudzien,
apilaskowski,
ikholopov-omni and
kolina
and removed request for
a team
Collaborator
|
LGTM from my side. Lets wait for @ikholopov-omni or @kolina to approve. |
Collaborator
|
Please add description to the change and to the field, so we can understand why does it exist and what purpose will it serve. |
ikholopov-omni
requested changes
Apr 20, 2026
Collaborator
ikholopov-omni
left a comment
ikholopov-omni
left a comment
There was a problem hiding this comment.
Please add description to proto and change
rafal-hawrylak
force-pushed
the
generic_compilation_options
branch
from
14f826d to
248abe3
Compare
Collaborator
Author
done |
kolina
reviewed
Apr 20, 2026
rafal-hawrylak
force-pushed
the
generic_compilation_options
branch
from
248abe3 to
277fe76
Compare
ikholopov-omni
approved these changes
Apr 21, 2026
kolina
approved these changes
Apr 21, 2026
| // distinct from `project_config_override.vars` (which holds user vars). | ||
| // This can be used to pass environment-specific parameters or | ||
| // auxiliary configuration paths to the underlying execution engine. | ||
| map<string, string> additional_options = 12; |
Contributor
There was a problem hiding this comment.
Let's clarify who will be providing this configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce generic configuration options for compilation
Adds the
additional_optionsfield toCompileConfig. This generic map allows the pipeline to supply auxiliary key-value parameters and paths necessary for compilation, keeping the core schema clean while supporting various environment-specific requirements.