Skip to content

Add compilation error when trying to add unit tests for unsupported actions#2154

Merged
kolina merged 1 commit into
mainfrom
add-compilation-error-tests-dag
May 9, 2026
Merged

Add compilation error when trying to add unit tests for unsupported actions#2154
kolina merged 1 commit into
mainfrom
add-compilation-error-tests-dag

Conversation

@fernst
Copy link
Copy Markdown
Collaborator

@fernst fernst commented May 1, 2026

Add formal check to ensure that unit tests are only added to the DAG for tables and views.

@fernst fernst requested a review from kolina May 1, 2026 16:49
@fernst fernst requested a review from a team as a code owner May 1, 2026 16:49
Comment thread core/session.ts
.find(test.getTestTarget())
.filter(action => action instanceof Table || action instanceof View)
.forEach(currentTest => {
const testTargets = this.indexedActions.find(currentTest.getTestTarget());
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test?

@kolina kolina merged commit ccef63c into main May 9, 2026
6 checks passed
@kolina kolina deleted the add-compilation-error-tests-dag branch May 9, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants