Fix io_runtime drop panic in test_postgres_io_runtime_segregation#560
Merged
lukekim merged 3 commits intoMar 13, 2026
Merged
Conversation
54ff9f9 to
3471d4d
Compare
hozan23
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
test_postgres_io_runtime_segregationtest panic mentioned in #559.The test creates a
tokio::runtime::Runtime(io_runtime) inside anasync fn. When the function returns, Rust dropsio_runtime, andRuntime::dropperforms a blocking shutdown to wait for spawned tasks. Since the test runs on a Tokio worker thread (via#[tokio::test]), blocking is not allowed — causing the panic:The fix calls
io_runtime.shutdown_background()before the end of the test, which consumes the runtime and initiates a non-blocking shutdown, avoiding the panic.Test plan
test_postgres_io_runtime_segregationno longer panics