feat: use gunicorn in production server instead of adev#85
Merged
bolinocroustibat merged 7 commits intomainfrom Jan 20, 2026
Merged
feat: use gunicorn in production server instead of adev#85bolinocroustibat merged 7 commits intomainfrom
bolinocroustibat merged 7 commits intomainfrom
Conversation
bolinocroustibat
force-pushed
the
remove-adev-from-production
branch
from
3e5ce8e to
cb2ef9c
Compare
Replace adev with python -m api_tabular.app for production deployments. Add CSVAPI_APP_PORT environment variable support. # Conflicts: # README.md
bolinocroustibat
force-pushed
the
remove-adev-from-production
branch
from
0dbb945 to
4093349
Compare
maudetes
reviewed
Jan 7, 2026
|
|
||
| def run(): | ||
| web.run_app(app_factory(), path=os.environ.get("CSVAPI_APP_SOCKET_PATH")) | ||
| socket_path = os.environ.get("CSVAPI_APP_SOCKET_PATH") |
Contributor
Author
There was a problem hiding this comment.
CSVAPI_APP_SOCKET_PATH you mean? Not as far as I know. Should we get rid of it?
bolinocroustibat
changed the title
# Conflicts: # pyproject.toml # uv.lock
bolinocroustibat
added a commit
that referenced
this pull request
Jan 22, 2026
Replace adev (dev server) with gunicorn for production deployments. - Add `gunicorn `to production dependencies - Add `CSVAPI_APP_PORT` environment variable support in `run()` functions - Update README with production server usage notes - Move `aiohttp-devtools` from production dependencies to dev dependency group (`pyproject.toml` and `uv.lock`) >⚠️ **WARNING:** This change requires a modified Dockerfile in the infra repository before deployment. The Dockerfile must be updated to use `gunicorn` instead of `adev` for this to work in production.
bolinocroustibat
added a commit
that referenced
this pull request
Jan 22, 2026
Replace adev (dev server) with gunicorn for production deployments. - Add `gunicorn `to production dependencies - Add `CSVAPI_APP_PORT` environment variable support in `run()` functions - Update README with production server usage notes - Move `aiohttp-devtools` from production dependencies to dev dependency group (`pyproject.toml` and `uv.lock`) >⚠️ **WARNING:** This change requires a modified Dockerfile in the infra repository before deployment. The Dockerfile must be updated to use `gunicorn` instead of `adev` for this to work in production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace adev (dev server) with gunicorn for production deployments.
gunicornto production dependenciesCSVAPI_APP_PORTenvironment variable support inrun()functionsaiohttp-devtoolsfrom production dependencies to dev dependency group (pyproject.tomlanduv.lock)