Use test client in tests

[Pierlou]

Instead of running the app in the background, we start the app using TestServer and TestClient, which will allow us to patch the config before starting the app

[maudetes]

Very neat 👌

[maudetes]

Do we still need this rmock?

[Pierlou]

I'd say yes, we want to pretend Postgrest has not started, but we could stop mocking the case where Postgrest is in place, as it actually is. I'll try that

[Pierlou]

I was planning on:

@pytest.mark.parametrize(
    "params",
    [
        (False, ["errors"]),
        (True, ["status", "version", "uptime_seconds"]),
    ],
)
async def test_health(client, rmock, params):
    has_postgrest_started, expected_keys = params
    if not has_postgrest_started:
        rmock.head(
            f"{config.PGREST_ENDPOINT}/migrations_csv",
            status=503,
        )
    res = await client.get("/health/")
    assert res.status == 200 if has_postgrest_started else 503
    res_json = await res.json()
    assert all(key in res_json for key in expected_keys)

but the migrations_csv table is not set up in this project's container, so the case has_postgrest_started=True fails. So we either:

• create the migrations_csv table in this project's setup
• keep the current syntax with two mocks

(it also means that the /health/ endpoint is currently only working when tabular is ran on a "real" hydra db)
We can decide and potentially make these changes in a second PR as it would be quite a change on its own.