feat(notifications): add localMarkAsRead and multi-page refresh#1121
Open
nicolaskempf57 wants to merge 1 commit into
Open
feat(notifications): add localMarkAsRead and multi-page refresh#1121nicolaskempf57 wants to merge 1 commit into
nicolaskempf57 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes datagouv/data.gouv.fr#2029
This PR adds a new
localMarkAsRead, that update the front-end notification data instead of refreshing it for every notification read. This is used when reading all notification without action, even with themarquer comme luesbutton.It also update the refresh function to handle refreshing multiple pages. This is used after handling notifications with actions (when we sometime don't have a direct access to the notification object).
We could apply the
localMarkAsReadeverywhere but that imply doing some matching to find the notification linked to the current event, which seems more error-prone than the refresh.