Merged
Conversation
nicolaskempf57
requested review from
ThibaudDauce and
maudetes
as code owners
ThibaudDauce
approved these changes
Dec 31, 2025
Contributor
ThibaudDauce
left a comment
ThibaudDauce
left a comment
There was a problem hiding this comment.
Just small changes… I'm confused on the aria-hidden on the SVG (but not a big expert in a11y), could you audit if we use icon-only with a default slot anywhere? We may remove the icon-only if we don't use the with icon-only anymore.
Contributor
Author
I removed this case because it was broken (the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.