spec: add topic-discovery ENR entry; rename discng key#6
Merged
Conversation
Define enr-entries/topic-discovery.md for the TopDisc topic discovery capability, with version-tagged unsigned-integer value so future non-backwards-compatible revisions can bump in place. Cross-reference the new entry from the ENR known-keys table in enr.md and from the TopDisc Capability section of discv5-theory.md.
srene
force-pushed
the
feat/enr-topic-discovery-entry
branch
from
41634f9 to
40e8f77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enr-entries/topic-discovery.mddefining thetopic-discoveryENR entry, which signals that a node implements the topic discovery capability for Discv5 and is willing to participate in topic service tables, registrations, and lookups.discv5/discv5-theory.mdfromdiscngtotopic-discovery, and links the theory section to the new entry doc.1.0. The new entry consistently uses1.Entry shape
Value is an unsigned integer rather than a presence-only flag so future non-backwards-compatible revisions can bump in place; implementations that do not understand a version SHOULD treat the node as if the entry were absent.
Files
enr-entries/topic-discovery.md(new)discv5/discv5-theory.md— section "DISC-NG Capability" renamed to "Topic Discovery Capability"; key renamed; cross-link added.Companion implementation PR
A matching go-ethereum PR will rename the ENR key and Go type names in the reference implementation.
Closes part of #5.