Skip to content

Conversation

@chriscollins3456
Copy link
Collaborator

We got a report of a white screen of death when loading the assertions tab on a dataset. It was due to a scenario where the datasetAssertionInfo is null and we destructure off of it. This was happening in DatasetAssertionsList component when generating the column with the result and description.

Ideally we would never get into this scenario but that would require a bigger refactor I don't have time to get into right now. So now we just handle the unsafe destructuring properly.

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Dec 10, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 10, 2025
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Dec 10, 2025

✅ Meticulous spotted 0 visual differences across 984 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit d63884e. This comment will update as new commits are pushed.

@AdrianMachado AdrianMachado self-requested a review December 10, 2025 21:36
@AdrianMachado AdrianMachado self-assigned this Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025

Bundle Report

Changes will increase total bundle size by 4 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.85MB 4 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 4 bytes 19.22MB 0.0%

Files in assets/index-*.js:

  • ./src/app/entityV2/shared/tabs/Dataset/Validations/DatasetAssertionDescription.tsx → Total Size: 13.89kB

@chriscollins3456 chriscollins3456 merged commit cf02c22 into master Dec 12, 2025
48 of 49 checks passed
@chriscollins3456 chriscollins3456 deleted the cc--fix-assertion-destructuring-white-screen branch December 12, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants