Skip to content

Add new parameters to project deployment creation #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marchelleboid merged 2 commits into from
Dec 11, 2020
Merged

Add new parameters to project deployment creation #109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acba07e
Add new parameters to project deployment creation
marchelleboid Dec 9, 2020
b75b5e8
Remove method to enable/disable project deployment
marchelleboid Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions dataikuapi/dss/projectdeployer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,23 +35,33 @@ def get_deployment(self, deployment_id):
"""
return DSSProjectDeployerDeployment(self.client, deployment_id)

def create_deployment(self, deployment_id, project_key, infra_id, bundle_id):
def create_deployment(self, deployment_id, project_key, infra_id, bundle_id,
deployed_project_key=None, project_folder_id=None):
"""
Creates a deployment and returns the handle to interact with it. The returned deployment
is not yet started and you need to call :meth:`~DSSProjectDeployerDeployment.start_update`

:param str deployment_id: Identifier of the deployment to create
:param str project_key: Identifier of the published project target
:param str project_key: The source published project key
:param str infra_id: Identifier of the deployment infrastructure to use
:param str bundle_id: Identifier of the bundle to deploy
:param str deployed_project_key: The project key to use when deploying this project to the automation node. If
not set, the project will be created with the same project key as the source
published project
:param str project_folder_id: The automation node project folder id to deploy this project into. If not set,
the project will be created in the root folder
:rtype: :class:`DSSProjectDeployerDeployment`
"""
settings = {
"deploymentId" : deployment_id,
"publishedProjectKey" : project_key,
"infraId" : infra_id,
"bundleId" : bundle_id
"deploymentId": deployment_id,
"publishedProjectKey": project_key,
"infraId": infra_id,
"bundleId": bundle_id
}
if deployed_project_key:
settings["deployedProjectKey"] = deployed_project_key
if project_folder_id:
settings["projectFolderId"] = project_folder_id
self.client._perform_json("POST", "/project-deployer/deployments", body=settings)
return self.get_deployment(deployment_id)

Expand Down Expand Up @@ -128,7 +138,7 @@ def create_project(self, project_key):
:rtype: :class:`DSSProjectDeployerProject`
"""
settings = {
"projectKey" : project_key
"publishedProjectKey": project_key
}
self.client._perform_json("POST", "/project-deployer/projects", body=settings)
return self.get_project(project_key)
Expand Down Expand Up @@ -292,10 +302,6 @@ def get_raw(self):
"""
return self.settings

def set_enabled(self, enabled):
"""Enables or disables this deployment"""
self.settings["enabled"] = enabled

def save(self):
"""Saves back these settings to the deployment"""
self.client._perform_empty(
Expand Down