add call to grab usage summary#155
Merged
FChataigner merged 2 commits intorelease/9.0from Jul 26, 2021
Merged
Conversation
|
This pull request has been linked to Clubhouse Story #58301: API to get global usage summary. |
| """ | ||
| Summarize the contents of the instance | ||
|
|
||
| :returns: a summary object |
Contributor
There was a problem hiding this comment.
Just to match the doc of other similar methods, I think we usually say it returns a dict rather than an object.
qcastel
reviewed
Jul 22, 2021
dataikuapi/dssclient.py
Outdated
| # Monitoring | ||
| ######################################################## | ||
|
|
||
| def get_global_usage_summary(self): |
Contributor
There was a problem hiding this comment.
From Marc's comment (https://github.com/dataiku/dip/pull/13032#discussion_r672957865), having an option to request the metrics per project would be cool
qcastel
approved these changes
Jul 26, 2021
marchelleboid
approved these changes
Jul 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ch58301]
no helper object, since it wouldn't bring much compared to just accessing fields in the object