Merged
Conversation
|
This pull request has been linked to Shortcut Story #76255: Python API: absolute imports break the ansible integration. |
Contributor
|
I verified that the python client still works as before, and it does. I'm not sure how to reproduce the original bug, so I haven't tested that. I did notice another absolute import here: https://github.com/dataiku/dataiku-api-client-python/blob/release/9.0/dataikuapi/dss/admin.py#L215 , does it also need to be changed to a relative import? |
Contributor
Author
|
The import you found should be change but has no impact on the ansible use case, it should be done in a PR to change all imports. Its a wider topic. Providing reproduction code in the shortcut card. |
AFrancani
approved these changes
Nov 29, 2021
Contributor
AFrancani
left a comment
AFrancani
left a comment
There was a problem hiding this comment.
Code LGTM
Successfully tested
marchelleboid
approved these changes
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ch76255]