Skip to content

Add Python client for Project deployer#96

Merged
AgatheG merged 6 commits intofeature/dss90-project-deployerfrom
feature/dss90-project-deployer-public-api
Nov 4, 2020
Merged

Add Python client for Project deployer#96
AgatheG merged 6 commits intofeature/dss90-project-deployerfrom
feature/dss90-project-deployer-public-api

Conversation

@AgatheG
Copy link
Copy Markdown
Contributor

@AgatheG AgatheG commented Sep 21, 2020

ch47130

See PR for the Public API on dip: https://github.com/dataiku/dip/pull/11101

@AgatheG AgatheG self-assigned this Sep 21, 2020
Comment thread dataikuapi/dss/projectdeployer.py
Comment thread dataikuapi/dss/projectdeployer.py Outdated
Comment thread dataikuapi/dss/projectdeployer.py
Comment thread dataikuapi/dss/apideployer.py
Comment thread dataikuapi/dss/projectdeployer.py
Also fix a forgotten code style mistake
@AgatheG AgatheG requested a review from marchelleboid October 13, 2020 10:16
@AgatheG AgatheG requested a review from mhoarau October 13, 2020 13:57
Copy link
Copy Markdown
Contributor

@marchelleboid marchelleboid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (only comment is the naming of the params on the other PR)

Copy link
Copy Markdown
Contributor

@mhoarau mhoarau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I did not extensively played with all the APIs though)

@AgatheG AgatheG merged commit 72b3646 into feature/dss90-project-deployer Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants