Fix Next page pagination x extraction path#16
Conversation
|
This pull request has been linked to Shortcut Story #76640: Next page pagination does not work combined with extraction path. |
JaneBellaiche
left a comment
JaneBellaiche
left a comment
There was a problem hiding this comment.
Bug fixed !
Another comment tho : a ValueError is raised if the extraction path is not found, but not if the Key to Next request URL is not found, is that expected ? Someone could have made a typo and if the first page is very big, he won't be able to see his mistake before really look into the output dataset
|
@JaneBellaiche regarding the lack of error raised when Key to Next request URL is not found: it's a tricky one, because we don't know for sure how the targeted API reacts when there is no more page to be loaded. Some might keep the key and leave it empty, others will drop the key. And I can't raise on first page only: the targeted API might report a variable amount of data, which means extra page on day 1 but not an day 2... |
2 participants
No description provided.