Fix for [sc-87910] broken rfc-5988 pagination mode on some servers#22
Merged
alexbourret merged 5 commits intomasterfrom May 19, 2022
Merged
Conversation
|
This pull request has been linked to Shortcut Story #87910: RFC-5988 pagination broken on some servers. |
Contributor
JaneBellaiche
left a comment
JaneBellaiche
left a comment
There was a problem hiding this comment.
The fix works as expected 👍
Aside from a little comment, LGTM
| params = self.requests_kwargs.get("params") | ||
| params.update(pagination_params) | ||
| self.requests_kwargs.update({"params": params}) | ||
| if self.pagination.params_must_be_blanked: |
Contributor
There was a problem hiding this comment.
can't you use if self.pagination.next_page_url instead of creating an additional arg?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.