Merged
Conversation
JaneBellaiche
approved these changes
Oct 11, 2023
Contributor
JaneBellaiche
left a comment
JaneBellaiche
left a comment
There was a problem hiding this comment.
Code LGTM + tested :
- brotli decompression ✅
- speed up of recurring calls ✅
- api_key_value removed from logs ✅
Comment on lines
+5
to
+13
| - Add Brotli compression | ||
| - Faster recurring calls | ||
| - Updated code-env descriptor for DSS 12 | ||
|
|
||
|
|
||
| ## [Version 1.1.4](https://github.com/dataiku/dss-plugin-api-connect/releases/tag/v1.1.4) - Feature and bugfix release - 2023-02-28 | ||
|
|
||
| - Add Brotli compression | ||
| - Faster recurring calls |
Contributor
There was a problem hiding this comment.
why brotli and faster recurring calls are mentioned in two versions ?
Bug/sc 133490 stable output schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.