feat(model): remove coreference resolution task#286
Merged
hanneshapke merged 6 commits intomainfrom Mar 31, 2026
Merged
Conversation
…tion Remove the coreference resolution task from the entire training pipeline to dedicate 100% of encoder capacity to PII detection. This simplifies the model architecture, training, evaluation, and ONNX export. Changes across model.py, trainer.py, config.py, preprocessing.py, tokenization.py, quantitize.py, train.py, eval_model.py, eval_model_detailed.py, compare_models.py, and training_pipeline.py. Closes #259
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MultiTaskPIIDetectionModel→PIIDetectionModel,MultiTaskTrainer→PIIModelTrainerMultiTaskLoss, coref classifier, coref loss weights, coref metricscreate_coreference_samplefrom tokenization.pypii_logitsMotivation
The coref task competes for model capacity with noisy synthetic supervision and untuned loss weights. Removing it dedicates 100% of encoder gradients to PII detection — the primary and most critical task. This also simplifies the codebase significantly (-693 lines).
Test plan
Closes #259