Add support for curly brackets in comments #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guzman-raphael
requested changes
May 28, 2021
There was a problem hiding this comment.
@Synicix Thanks man. Good work on this. The fix is straightforward here so good with that. Have feedback mainly related to test, style, and some typos.
We should also appropriately update the version and release log. Linking examples from another PR in how we usually do this in datajoint-matlab.
Also, the tests are failing b/c you pointed from your fork to master w/o going through a stage step first. I know there is another #369 already pointed to stage but I created a separate copy in stage2 to prevent collisions for you. You can safely point this PR there.
guzman-raphael
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.