Skip to content

Conversation

neuralsignal
Copy link
Contributor

When setting the fetch_format to 'frame' in the dj.config, using attributes in fetch gives an error.

This was easily fixed by setting format='array', when fetch is called again within "if attrs:"

Copy link
Collaborator

@guzman-raphael guzman-raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you add a unit test to cover this?

@neuralsignal
Copy link
Contributor Author

I have added a test

Copy link
Member

@dimitri-yatsenko dimitri-yatsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

Copy link
Collaborator

@guzman-raphael guzman-raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome man. Thanks for the PR!

@guzman-raphael guzman-raphael merged commit 9e6cd0e into datajoint:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants