Only install bokeh if not running via emscripten#53
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=======================================
Coverage 27.46% 27.46%
=======================================
Files 4 4
Lines 477 477
=======================================
Hits 131 131
Misses 346 346 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ml-evs
force-pushed
the
ml-evs/add-emscripten-carve-out
branch
2 times, most recently
from
8b431b6 to
7118b48
Compare
Bump and run pre-commit linters Use latest uv in CI Linting Use uv in RTD config
ml-evs
force-pushed
the
ml-evs/add-emscripten-carve-out
branch
from
7118b48 to
869b887
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of testing out WASM in https://github.com/datalab-org/datalab-api-wasm-plugin, bokeh cannot be installed by micropip, so we try to prevent its installation when using the emscripten backend.
Plus minor linting and docs updates.