Skip to content

Conversation

@ml-evs
Copy link
Member

@ml-evs ml-evs commented Dec 12, 2025

Closes #283.

Mongomock has not been working for some time and adds extra complexity to our testing setup. This PR removes it entirely and expects developers to run a local MongoDB.

Also removes some defunct legacy scripts.

@ml-evs ml-evs added testing For issues/PRs that change how the package is tested Python labels Dec 12, 2025
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.13%. Comparing base (a52ff8b) to head (bac9915).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1492   +/-   ##
=======================================
  Coverage   79.13%   79.13%           
=======================================
  Files          70       70           
  Lines        5219     5219           
=======================================
  Hits         4130     4130           
  Misses       1089     1089           
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/mongo.py 80.82% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Dec 12, 2025

datalab    Run #4330

Run Properties:  status check passed Passed #4330  •  git commit 65e4890355 ℹ️: Merge bac99155d071c2ff989d5e940bd0e8bfe4b940ff into a52ff8bd278a0837b4f69ae326ff...
Project datalab
Branch Review ml-evs/remove-mongomock
Run status status check passed Passed #4330
Run duration 09m 27s
Commit git commit 65e4890355 ℹ️: Merge bac99155d071c2ff989d5e940bd0e8bfe4b940ff into a52ff8bd278a0837b4f69ae326ff...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 458
View all changes introduced in this branch ↗︎

@ml-evs ml-evs merged commit 22f70a4 into main Dec 13, 2025
15 checks passed
@ml-evs ml-evs deleted the ml-evs/remove-mongomock branch December 13, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Python testing For issues/PRs that change how the package is tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix or remove local testing with mongomock

2 participants