Allow deletion of orphan output nodes! #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goanpeca
force-pushed
the
enh/orphan-output-nodes
branch
from
c8660d0 to
c6b9f84
Compare
goanpeca
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR addresses orphaned output nodes in Jupyter notebooks by allowing their selection and deletion. When input cells are deleted, their associated output nodes can become orphaned, and this change provides a mechanism to identify and clean up these orphaned nodes.
- Added utility function to detect orphaned output nodes
- Modified output node behavior to make orphaned nodes selectable and deletable
- Preserved protection for output nodes with valid parent input nodes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/lexical/src/nodes/JupyterOutputNodeUtils.ts | New utility file with function to detect orphaned output nodes |
| packages/lexical/src/nodes/JupyterOutputNode.tsx | Updated output node class to allow selection and deletion of orphaned nodes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
goanpeca
force-pushed
the
enh/orphan-output-nodes
branch
from
c6b9f84 to
f1dadaa
Compare
echarles
approved these changes
Oct 18, 2025
goanpeca
force-pushed
the
enh/orphan-output-nodes
branch
from
f1dadaa to
ba89989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes datalayer/vscode-datalayer#28
So, maybe something still needs to be fixed on lexical loro side, but this allows selection and deletion of orphaned output cells which is what the bug manifested as.
We should probably not get to this state in the first place, but at least this allows to delete the orphan output nodes for documents that resulted in this.