Skip to content

Fix exporting of alerts with notification activity or app setting overrides #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nblumhardt merged 3 commits into from
Oct 10, 2022
Merged

Fix exporting of alerts with notification activity or app setting overrides #255

nblumhardt merged 3 commits into from
Oct 10, 2022

Conversation

@nblumhardt
Copy link
Member

@nblumhardt nblumhardt commented Oct 10, 2022

  • Alert notification history shouldn't be exported at all
  • Setting overrides are string/string dictionaries, which weren't previously handled at all

Fixes #248

KodrAus
KodrAus approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nblumhardt nblumhardt merged commit b2f2a53 into datalust:dev Oct 10, 2022
@nblumhardt nblumhardt mentioned this pull request Oct 14, 2022
Merged
@nblumhardt nblumhardt mentioned this pull request Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KodrAus KodrAus KodrAus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Errors exporting alerts during template export

2 participants

@nblumhardt @KodrAus