Skip to content

Bench upgrades #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liammclennan merged 6 commits into from
Dec 4, 2022
Merged

Bench upgrades #264

liammclennan merged 6 commits into from
Dec 4, 2022

Conversation

@liammclennan
Copy link
Contributor

@liammclennan liammclennan commented Dec 1, 2022

  • 'Server' property is wrong
  • Add a label arg to describe what the bench run is testing
  • Make start and end required to remove ambiguity
  • Make cases hash consistent

nblumhardt
nblumhardt reviewed Dec 1, 2022
View reviewed changes
@liammclennan liammclennan merged commit eec5f5e into datalust:dev Dec 4, 2022
@liammclennan liammclennan deleted the bench-upgrades branch December 4, 2022 23:24
@nblumhardt nblumhardt mentioned this pull request Jan 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nblumhardt nblumhardt nblumhardt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liammclennan @nblumhardt