Feature/stream name root table canonicalization#131
Merged
AlexanderMann merged 9 commits intodatamill-co:masterfrom Aug 20, 2019
Merged
Conversation
AlexanderMann
commented
Jul 30, 2019
…tside of postgres
…hem via get_table_schema
3f8c5dc to
38baae4
Compare
Collaborator
Author
|
Of note: I realized recently that we assume all the time that there is only one target running per db all the time. This is due to us using transactions on the db, so something should just fail quickly if there's a conflict etc. |
awm33
approved these changes
Aug 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#102
target-redshiftas well astarget-postgresNotes
This will break instances where multiple versions of
target-postgresare trying to upsert different streams (taps) to the same remote.I'm unsure as to whether we want to support this use case.
ie, as a user, I have a long running tap persisting data to postgres db A, via
target-postgres v0.1.8. I also want to be able to run the latesttarget-postgres v0.1.Xto persist anothertapto db A.Suggested Musical Pairing
https://soundcloud.com/snottynoserezkids/sets/snotty-nose-rez-kids-lp