Fix: Type suffixes/shorthands are not necissarily canonicalized#144
Merged
AlexanderMann merged 1 commit intodatamill-co:masterfrom Aug 28, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Presently we generate type suffixes for columns on type splits/name collisions. These suffixes are not necessarily canonicalized appropriately for a given target.
To handle this, we should only ever create or use a canonicalized identifier IFF we have called
self.canonicalize_identifier.Notes
This issue was not encountered with Postgres or Redshift. This is purely a problem for https://github.com/datamill-co/target-snowflake which is still solidly in beta.
Suggested Musical Pairing
Economist Radio