Skip to content

Feature/all of support#154

Merged
AlexanderMann merged 8 commits intodatamill-co:masterfrom
AlexanderMann:feature/allOf-support
Jan 16, 2020
Merged

Feature/all of support#154
AlexanderMann merged 8 commits intodatamill-co:masterfrom
AlexanderMann:feature/allOf-support

Conversation

@AlexanderMann
Copy link
Copy Markdown
Collaborator

Motivation

#14

This pr seeks to add full support for allOf to Target-Postgres.

This is done in a couple ways:

  • validation of all records against the raw schema (not our simplified one)
    • we assume that impossible schemas will simply error violently here and thus we don't need to check for them later on
  • simplification of the schema does a few things for allOf:
    • prefer datetimes
    • prefer literals
    • nullables break ties
    • merge all objects together
    • recurse (includes support for $refs in allOf!)

@AlexanderMann AlexanderMann merged commit 362665f into datamill-co:master Jan 16, 2020
@AlexanderMann AlexanderMann deleted the feature/allOf-support branch January 16, 2020 15:51
@AlexanderMann AlexanderMann restored the feature/allOf-support branch April 10, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants