feat: Metric/Measurement split#29
Merged
CasperTeirlinck merged 4 commits intomainfrom Apr 21, 2026
Merged
Conversation
This was referenced Apr 21, 2026
Merged
jvanbuel
requested changes
Apr 21, 2026
jvanbuel
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the use of Metrics as classes to Metrics as instances.
For background info and justification why, see this ADR: #28.
The main changes are:
Measurement. TheMetricdefines and configures the metric, theMeasurementholds the value and diagnostic from that metric when it is measured.Because this is a refactor of one of the core implementation details, this PR touches a lot of files, but edits in most files are quite minimal. The main changes are in
src/checkup/metric.pyand the other edits is making the other components work with the new Measurement class.