TUL/Reduce warn logs noise - 404 dedicated logger#1279
Merged
milanmajchrak merged 1 commit intocustomer/TULfrom Mar 16, 2026
Merged
TUL/Reduce warn logs noise - 404 dedicated logger#1279milanmajchrak merged 1 commit intocustomer/TULfrom
milanmajchrak merged 1 commit intocustomer/TULfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces REST API log noise by routing 404 (NOT_FOUND) client errors to a dedicated Log4j2 logger that is OFF by default, while refactoring the exception handler to centralize client-error logging and status-code configuration.
Changes:
- Add a dedicated Log4j2 logger (
org.dspace.app.rest.exception.DSpaceApiExceptionControllerAdvice.NotFound) configured OFF by default. - Introduce a dedicated
notFoundLoglogger and alogClientError()helper to route 404s separately from other 4xx warnings. - Extract status-code parsing into
getStatusCodesLoggedAsErrors()and add a newsendErrorResponseFromException()helper (currently unused).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
dspace/config/log4j2.xml |
Adds an OFF-by-default logger dedicated to 404 REST responses. |
dspace-server-webapp/src/main/java/org/dspace/app/rest/exception/DSpaceApiExceptionControllerAdvice.java |
Adds dedicated 404 logger + helper methods to reduce 404 warn noise and refactor logging/status-code handling. |
You can also share your feedback on Copilot code review. Take the survey.
...r-webapp/src/main/java/org/dspace/app/rest/exception/DSpaceApiExceptionControllerAdvice.java
Outdated
Show resolved
Hide resolved
...r-webapp/src/main/java/org/dspace/app/rest/exception/DSpaceApiExceptionControllerAdvice.java
Outdated
Show resolved
Hide resolved
...r-webapp/src/main/java/org/dspace/app/rest/exception/DSpaceApiExceptionControllerAdvice.java
Outdated
Show resolved
Hide resolved
d2b67c3 to
172cc68
Compare
172cc68 to
2a53308
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of commits 1dc5339 and db67645 into customer/TUL.
Problem description
Original commits: