VSB-TUO/feat: SAF Import/Update – embargo improvements & item page display

[milanmajchrak]

Problem description

1. Embargo date +1 day – Resource policy startDate = dc.date.embargoend + 1 day (file becomes accessible the day after embargo ends).
2. Tests – Updated embargo assertions for +1 day. Added testSafUpdateMetadataAndEmbargo integration test.

Modified files

• ItemImportServiceImpl.java – processEmbargoMetadata(), replaceItems(), new removeEmbargoFromItemBitstreams()
• EmbargoImportIT.java – updated assertions, new test

Analysis

(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)

Problems

(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)

Manual Testing (if applicable)

• Added to testing scenarios

Copilot review

• Requested review from Copilot

[Copilot]

Pull request overview

Updates SAF import embargo handling and extends integration coverage around embargo behavior during imports and replacements/updates.

Changes:

• Shift embargo ResourcePolicy start date to embargoend + 1 day in import processing and update related assertions.
• Refactor replaceItems() behavior to update existing items’ metadata/embargo/licenses instead of delete + re-import.
• Add an integration test covering SAF “replace/update” of metadata + embargo on an existing item.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
dspace-api/src/test/java/org/dspace/app/itemimport/EmbargoImportIT.java	Updates embargo start-date expectations and adds a SAF update/replace integration test.
dspace-api/src/main/java/org/dspace/app/itemimport/ItemImportServiceImpl.java	Changes replace behavior to metadata/embargo update, adjusts embargo start-date calculation, and adds embargo-policy removal helper.

---

You can also share your feedback on Copilot code review. Take the survey.