Skip to content

MENDELU/OAI-PMH - removed type conversions - it is now changed in the metadata#1295

Merged
milanmajchrak merged 1 commit intocustomer/mendelufrom
mendelu/type-change-oai
Mar 26, 2026
Merged

MENDELU/OAI-PMH - removed type conversions - it is now changed in the metadata#1295
milanmajchrak merged 1 commit intocustomer/mendelufrom
mendelu/type-change-oai

Conversation

@milanmajchrak
Copy link
Copy Markdown
Collaborator

Problem description

Analysis

(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)

Problems

(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)

Manual Testing (if applicable)

Copilot review

  • Requested review from Copilot

Copilot AI review requested due to automatic review settings March 26, 2026 09:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies MENDELU’s OAI-PMH configuration by removing custom dc.type conversions from the OAI-DC XSL and the XOAI DRIVER document-type filter, assuming type normalization is now handled in metadata values upstream.

Changes:

  • Removed legacy/localized dc.type value mappings from the OAI-DC (oai_dc.xsl) crosswalk and now outputs raw type values plus an info:eu-repo/semantics/-prefixed variant.
  • Removed legacy Czech dc.type strings from the XOAI DRIVER document type filter value list.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
dspace/config/crosswalks/oai/xoai.xml Removes legacy Czech dc.type values from the DRIVER document-type matching filter.
dspace/config/crosswalks/oai/metadataFormats/oai_dc.xsl Removes dc.type normalization logic; outputs raw dc.type and a prefixed semantics form.
Comments suppressed due to low confidence (1)

dspace/config/crosswalks/oai/xoai.xml:566

  • By removing the legacy Czech dc.type values from this DRIVER document-type filter, any existing items still using those values will no longer match driverDocumentTypeCondition and may be excluded from DRIVER/OpenAIRE set exports. If the repository can still contain legacy values, consider keeping the legacy strings during a transition period or ensure a data migration is applied before deploying this config change.
                <string name="operator">ends_with</string>
                <list name="values">
                    <string>article</string>
                    <string>bachelorThesis</string>
                    <string>masterThesis</string>
                    <string>doctoralThesis</string>
                    <string>book</string>
                    <string>bookPart</string>
                    <string>review</string>
                    <string>conferenceObject</string>

@milanmajchrak milanmajchrak merged commit d0996db into customer/mendelu Mar 26, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants