MENDELU/OAI-PMH Updated citation format and added ispartof metadatum into dc.relation

[milanmajchrak]

Problem description

Update because of citacePRO citations.

Analysis

(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)

Problems

(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)

Manual Testing (if applicable)

• Added to testing scenarios

Copilot review

• Requested review from Copilot

[Copilot]

Pull request overview

Updates the OAI-PMH oai_dc crosswalk to adjust how citation-like identifiers are formatted and to expose dc.relation.ispartof within the standard dc:relation element for better Dublin Core compatibility.

Changes:

• Updated formatted dc:identifier citation string (punctuation and removed ISSN inclusion).
• Remapped dc.relation.ispartof output from a custom element (dc:identifier.ispartof) to standard <dc:relation>.

[Copilot]

The citation formatter emits the ", vol." and ", č." segments unconditionally (lines 124-127), but the xsl:if guard (line 119) only requires any of issued/volume/number to exist. If (for example) only dc.date.issued is present, the output will still include empty volume/number placeholders and punctuation. Consider building the string with per-field conditionals (and separators) so missing fields don’t produce dangling commas/labels.

Suggested change

	<xsl:text>, vol. </xsl:text>
	<xsl:value-of select="doc:metadata/doc:element[@name='local']/doc:element[@name='volume']/doc:element/doc:field[@name='value']" />
	<xsl:text>, č. </xsl:text>
	<xsl:value-of select="doc:metadata/doc:element[@name='local']/doc:element[@name='number']/doc:element/doc:field[@name='value']" />
	<xsl:if test="doc:metadata/doc:element[@name='local']/doc:element[@name='volume']/doc:element/doc:field[@name='value']">
	<xsl:text>, vol. </xsl:text>
	<xsl:value-of select="doc:metadata/doc:element[@name='local']/doc:element[@name='volume']/doc:element/doc:field[@name='value']" />
	</xsl:if>
	<xsl:if test="doc:metadata/doc:element[@name='local']/doc:element[@name='number']/doc:element/doc:field[@name='value']">
	<xsl:text>, č. </xsl:text>
	<xsl:value-of select="doc:metadata/doc:element[@name='local']/doc:element[@name='number']/doc:element/doc:field[@name='value']" />
	</xsl:if>

[Copilot]

The formatted citation dc:identifier now unconditionally outputs dc.relation.ispartof (line 121), but the surrounding xsl:if guard (line 119) doesn’t check for ispartof. If issued/volume/number exist but ispartof is missing, this will emit a leading ". " and an incomplete citation. Consider either including ispartof in the xsl:if condition, or wrapping the ispartof output (and its trailing punctuation) in its own conditional to avoid stray punctuation and empty segments.

[Copilot]

This PR changes the OAI-PMH oai_dc.xsl output (formatted dc:identifier and mapping dc.relation.ispartof). There are existing stylesheet tests for other metadataFormats (e.g., QDCXslTest/RioxxXslTest via AbstractXSLTest), but none appear to cover oai_dc.xsl. Please add/extend a stylesheet test to assert the updated citation formatting and that ispartof is emitted as dc:relation (and no longer as a custom element), to prevent regressions.