UFAL/Updated PR template #1056
Merged
UFAL/Updated PR template #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the pull request template by removing the time tracking table and adding a checklist item for i18n file synchronization verification.
- Removed the phases/time tracking table that included columns for MP, MM, MB, MR, JM
- Added a checklist reminder to verify sync-i18n-files script execution when translation files are updated
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
milanmajchrak
requested changes
Oct 28, 2025
.github/pull_request_template.md
Outdated
| (Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.) | ||
|
|
||
| If you updated en.json5 or cs.json5 file with translations: | ||
| - [ ] Verify the sync-i18n-files script was executed and any changes are included in this PR. |
Collaborator
There was a problem hiding this comment.
Add there info that only for the language you have updated
milanmajchrak
approved these changes
Oct 30, 2025
milanmajchrak
requested changes
Oct 30, 2025
.github/pull_request_template.md
Outdated
| - [ ] Run `yarn run sync-i18n -t src/assets/i18n/cs.json5 -i` to synchronize messages, and changes are included in this PR. | ||
|
|
||
| ### Manual Testing (if applicable) | ||
| - [ ] Added to testing scenarios. |
Collaborator
There was a problem hiding this comment.
Add there a link to that issue
milanmajchrak
previously approved these changes
Oct 30, 2025
vidiecan
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Reported issues
Not-reported issues
Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)