ZCU-PUB/Display full community path in sidebar search results#1235
Merged
milanmajchrak merged 6 commits intocustomer/zcu-pubfrom Mar 17, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates sidebar search list elements to show a full hierarchical parent path (breadcrumbs) for Communities and Collections in the sidebar search modal, improving context when selecting parents during creation workflows.
Changes:
- Updated
SidebarSearchListElementComponent.getParentTitle()to useDSOBreadcrumbsService.getBreadcrumbs()for Communities/Collections and join ancestors into a full path. - Extended sidebar-search list element components (Community/Collection/Person) to inject
DSOBreadcrumbsServiceafter updating the base component constructor. - Enhanced the shared sidebar-search list element test factory to provide a
DSOBreadcrumbsServicemock.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts |
Builds full parent path for community/collection results via breadcrumbs service. |
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.spec.ts |
Adds breadcrumbs service mock to shared test factory. |
src/app/shared/object-list/sidebar-search-list-element/community/community-sidebar-search-list-element.component.ts |
Fixes selector and wires constructor deps through to updated base class. |
src/app/shared/object-list/sidebar-search-list-element/collection/collection-sidebar-search-list-element.component.ts |
Wires constructor deps through to updated base class. |
src/app/entity-groups/research-entities/item-list-elements/sidebar-search-list-elements/person/person-sidebar-search-list-element.component.ts |
Adds missing breadcrumbs service injection and passes it to base constructor. |
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts
Outdated
Show resolved
Hide resolved
...shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.spec.ts
Show resolved
Hide resolved
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts
Outdated
Show resolved
Hide resolved
...pp/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.html
Outdated
Show resolved
Hide resolved
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts
Show resolved
Hide resolved
...shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.spec.ts
Show resolved
Hide resolved
...shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.spec.ts
Show resolved
Hide resolved
Collaborator
Author
|
@milanmajchrak If we want to include this PR, we should also offer it to Vanilla and cherry-pick it for other customers (mainly dtq-dev). |
milanmajchrak
requested changes
Mar 10, 2026
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@milanmajchrak I wanted to add it to scenarios earlier, but then I realized we should first merge it into dtq-dev (zcu-pub isn’t used for testing). |
milanmajchrak
approved these changes
Mar 16, 2026
vidiecan
approved these changes
Mar 17, 2026
Paurikova2
added a commit
that referenced
this pull request
Mar 19, 2026
* Show full community hierarchy in sidebar search * Add tooltip to parent path * Add shareReplay, type guard, and hierarchical path tests * refactor: unwrap parentTitle$ once, extract BREADCRUMB_SEPARATOR, fix tests * test: use createNoContentRemoteDataObject$ for safe fallback mock * Removed unsafe type cast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Display the complete hierarchical path from root to parent for communities
and collections in the sidebar search modal, instead of showing only the
immediate parent.
Changes:
DSOBreadcrumbsService.getBreadcrumbs() for communities/collections,
building full hierarchical path (e.g., "Test / FKU" instead of "FKU")
values, as REST API deserializes type as plain string
missing dsoBreadcrumbsService parameter
breadcrumb testing
Impact:
When creating new Collections or Communities, users now see the complete
path context in search results (e.g., "Test / FKU / Home" hierarchy),
making it easier to identify and select the correct parent community.
Manual Testing (if applicable)
Copilot review