ZCU-DATA/Cherry-pick Fix duplicate id#1240
Merged
milanmajchrak merged 2 commits intocustomer/zcu-datafrom Mar 11, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a duplicate HTML id used by the header search navbar by replacing it with a CSS class and updating test selectors accordingly, preventing duplicate-ID failures across pages where multiple search navbars can be rendered.
Changes:
- Replaced
id="search-navbar-container"withclass="search-navbar-container"in the search navbar template. - Updated Angular unit test selectors to use the new class-based selector.
- Removed the Cypress a11y exclusion comment that referenced the now-fixed duplicate ID.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/search-navbar/search-navbar.component.html | Removes the duplicate id and introduces a class for styling/selection. |
| src/app/search-navbar/search-navbar.component.spec.ts | Updates DOM queries from #search-navbar-container to .search-navbar-container. |
| cypress/e2e/header.cy.ts | Removes an outdated comment excluding the old duplicate-ID selector from a11y tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Found duplicate id in html
and
Sync verification
If en.json5 or cs.json5 translation files were updated:
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
Copilot review