VSB-TUO/Fix duplicate id#1245
Merged
milanmajchrak merged 1 commit intocustomer/vsb-tuofrom Mar 11, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR resolves duplicate HTML id attributes detected on /home (and other pages) by removing the duplicated IDs from the login/logout dropdown menus and the search navbar container, replacing them with class selectors and updating affected styling/tests accordingly.
Changes:
- Replace
id="loginDropdownMenu",id="logoutDropdownMenu", andid="search-navbar-container"with equivalent CSS classes to eliminate duplicate IDs. - Update SCSS selectors from
#...to....in both default and custom theme components. - Update the AuthNavMenu unit test selector to match the new class-based markup.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/themes/custom/app/shared/auth-nav-menu/auth-nav-menu.component.scss | Switch dropdown styling selectors from IDs to classes in the custom theme. |
| src/themes/custom/app/shared/auth-nav-menu/auth-nav-menu.component.html | Remove duplicated dropdown IDs (use classes instead) in the custom theme template. |
| src/themes/custom/app/search-navbar/search-navbar.component.html | Remove duplicated search navbar container ID (use class instead) in the custom theme template. |
| src/app/shared/auth-nav-menu/auth-nav-menu.component.spec.ts | Update test DOM query to use the new class selector. |
| src/app/shared/auth-nav-menu/auth-nav-menu.component.scss | Switch dropdown styling selectors from IDs to classes in the default theme. |
| src/app/shared/auth-nav-menu/auth-nav-menu.component.html | Remove duplicated dropdown IDs (use classes instead) in the default theme template. |
| src/app/search-navbar/search-navbar.component.html | Add a class to the search navbar container (aligning with the themed template, avoiding IDs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Found duplicity ids in html:
Sync verification
If en.json5 or cs.json5 translation files were updated:
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
Copilot review