ZCU-DATA/Fix-author-redirect#1297
Merged
milanmajchrak merged 1 commit intoMay 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the author link generation in the CLARIN shared utilities so that clicking an author always redirects to a search filtered by the author’s display name (instead of an ORCID/authority identifier), while still using ORCID data only for the optional ORCID icon/profile link.
Changes:
- Simplified author search-link composition to always use
authorMV.valuewith theequalsoperator. - Kept ORCID authority parsing solely for generating the external ORCID profile URL/icon link.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
When clicking on author with orcid id, the redirect should be with name of author not like this:
http://dev-5.pc:89/search?f.author=0000-1234-5678-9123,authority
Sync verification
If en.json5 or cs.json5 translation files were updated:
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
Copilot review